[PATCH 5/6] mfd: cros_ec_dev: Check communication with ec at resume

From: Enric Balletbo i Serra
Date: Mon Feb 19 2018 - 17:41:22 EST


From: Gwendal Grignou <gwendal@xxxxxxxxxxxx>

Send dummy command to EC at resume time, wait for status.
If EC loses that command and return a status for the
pre-suspend command, we will not interpret that status as an
answer for an important command.

Signed-off-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
---
drivers/mfd/cros_ec_dev.c | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
index fc98e0564061..c901839317ae 100644
--- a/drivers/mfd/cros_ec_dev.c
+++ b/drivers/mfd/cros_ec_dev.c
@@ -553,6 +553,16 @@ static __maybe_unused int ec_device_suspend(struct device *dev)
static __maybe_unused int ec_device_resume(struct device *dev)
{
struct cros_ec_dev *ec = dev_get_drvdata(dev);
+ char msg[sizeof(struct ec_response_get_version) +
+ sizeof(CROS_EC_DEV_VERSION)];
+ int ret;
+
+ /* Be sure the communication with the EC is reestablished */
+ ret = ec_get_version(ec, msg, sizeof(msg));
+ if (ret < 0) {
+ dev_err(ec->ec_dev->dev, "No EC response at resume: %d\n", ret);
+ return 0;
+ }

lb_resume(ec);

--
2.16.1