Re: [PATCH 2/2 v3] tpm: separate cmd_ready/go_idle from runtime_pm

From: Jarkko Sakkinen
Date: Tue Feb 20 2018 - 09:13:40 EST


On Mon, 2018-02-19 at 13:52 +0200, Jarkko Sakkinen wrote:
> On Wed, Feb 14, 2018 at 03:43:19PM +0200, Tomas Winkler wrote:
> > We cannot use go_idle cmd_ready commands via runtime_pm handles
> > as with the introduction of localities this is no longer an
> > optional
> > feature, while runtime pm can be not enabled.
> > Though cmd_ready/go_idle provides power saving feature, it's also
> > part of
> > TPM2 protocol and should be called explicitly.
> > This patch exposes cmd_read/go_idle via tpm class ops and removes
> > runtime pm support as it is not used by any driver.
> >
> > Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> > ---
> > V2: resent
> > V3: resent
>
> Only the cover letter needs a backlog but the code change looks
> good to me.
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>

Tested-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>

/Jarkko