Re: [PATCH 0/3] platform/chrome: cros_ec debugfs and sysfs updates

From: Andy Shevchenko
Date: Wed Feb 21 2018 - 14:09:55 EST


On Wed, Feb 21, 2018 at 4:49 PM, Enric Balletbo i Serra
<enric.balletbo@xxxxxxxxxxxxx> wrote:
> Hi,
>
> This patchset is another recopilation of some patches that were send
> before but never merged.
>
> First patch was already sent [1] but did not receive feedback so I am
> resending it. Needs to go throught platform/chrome tree and can be
> picked without dependencies.
>
> The second patch is new, like the first needs to go throught
> platform/chrome tree and can be picked without dependecies.
>
> Finally, the third patch was already sent [2] but now needed to be
> reworked due the split of the cros_ec_devs in 2 parts [3]. This patch
> touches platform/chrome and mfd so we will probably need an immutable
> branch when is ok.
>

New patches should have a tag, but there is, I hope, no need to resend
and maintainers would add them as I posted.

The rest looks good to me, FWIW,

Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

> Best regards,
> Enric
>
> [1] https://patchwork.kernel.org/patch/9894655/
> [2] https://www.mail-archive.com/linux-kernel@xxxxxxxxxxxxxxx/msg1488891.html
> [3] https://lkml.org/lkml/2017/11/20/408
>
> Gwendal Grignou (2):
> platform/chrome: cros_ec_sysfs: Modify error handling
> platform/chrome: mfd/cros_ec_dev: Add sysfs entry to set keyboard wake
> lid angle
>
> Shawn Nematbakhsh (1):
> platform/chrome: cros_ec_debugfs: Add PD port info to debugfs
>
> drivers/mfd/cros_ec_dev.c | 19 +++---
> drivers/platform/chrome/cros_ec_debugfs.c | 86 ++++++++++++++++++++++--
> drivers/platform/chrome/cros_ec_sysfs.c | 108 ++++++++++++++++++++++++------
> include/linux/mfd/cros_ec.h | 1 +
> 4 files changed, 180 insertions(+), 34 deletions(-)
>
> --
> 2.16.1
>



--
With Best Regards,
Andy Shevchenko