Re: [PATCH v3 2/4] gpio: Add GPIO driver for Nintendo Wii

From: Jonathan NeuschÃfer
Date: Thu Feb 22 2018 - 08:08:48 EST


On Thu, Feb 22, 2018 at 01:57:07PM +0100, Linus Walleij wrote:
> On Fri, Feb 9, 2018 at 1:07 PM, Jonathan NeuschÃfer
> <j.neuschaefer@xxxxxxx> wrote:
>
> > The Nintendo Wii's chipset (called "Hollywood") has a GPIO controller
> > that supports a configurable number of pins (up to 32), interrupts, and
> > some special mechanisms to share the controller between the system's
> > security processor (an ARM926) and the PowerPC CPU. Pin multiplexing is
> > not supported.
> >
> > This patch adds a basic driver for this GPIO controller. Interrupt
> > support will come in a later patch.
> >
> > This patch is based on code developed by Albert Herranz and the GameCube
> > Linux Team, file arch/powerpc/platforms/embedded6xx/hlwd-gpio.c,
> > available at https://github.com/DeltaResero/GC-Wii-Linux-Kernels, but
> > has grown quite dissimilar.
> >
> > Signed-off-by: Jonathan NeuschÃfer <j.neuschaefer@xxxxxxx>
> > Cc: Albert Herranz <albert_herranz@xxxxxxxx>
> > Cc: Segher Boessenkool <segher@xxxxxxxxxxxxxxxxxxx>
> > <---
> >
> > v3:
> > - Do some style cleanups, as suggest by Andy Shevchenko
>
> Patch applied to the GPIO tree for v4.17 with all the review tags.
>
> I just folded the changelog into the commit message, for new
> drivers it is sometimes useful to keep these around in
> git actually.
>
> If any further changes are needed we can just patch on top
> of this.
>
> It's a very pretty driver, good work!

Thanks! :-)


Jonathan NeuschÃfer

Attachment: signature.asc
Description: PGP signature