Re: [PATCH v12 07/11] mm: Add address parameter to arch_validate_prot()

From: Michael Ellerman
Date: Mon Feb 26 2018 - 00:54:46 EST


Khalid Aziz <khalid.aziz@xxxxxxxxxx> writes:

> A protection flag may not be valid across entire address space and
> hence arch_validate_prot() might need the address a protection bit is
> being set on to ensure it is a valid protection flag. For example, sparc
> processors support memory corruption detection (as part of ADI feature)
> flag on memory addresses mapped on to physical RAM but not on PFN mapped
> pages or addresses mapped on to devices. This patch adds address to the
> parameters being passed to arch_validate_prot() so protection bits can
> be validated in the relevant context.
>
> Signed-off-by: Khalid Aziz <khalid.aziz@xxxxxxxxxx>
> Cc: Khalid Aziz <khalid@xxxxxxxxxxxxxx>
> Reviewed-by: Anthony Yznaga <anthony.yznaga@xxxxxxxxxx>
> ---
> v8:
> - Added addr parameter to powerpc arch_validate_prot() (suggested
> by Michael Ellerman)
> v9:
> - new patch
>
> arch/powerpc/include/asm/mman.h | 4 ++--
> arch/powerpc/kernel/syscalls.c | 2 +-

These changes look fine to me:

Acked-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx> (powerpc)

cheers