Re: [PATCH v1 3/4] ACPI / sleep: Re-use new dmi_get_bios_year() helper

From: Jean Delvare
Date: Mon Feb 26 2018 - 11:32:03 EST


On Thu, 22 Feb 2018 14:59:22 +0200, Andy Shevchenko wrote:
> ...instead of open coding its functionality.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/acpi/sleep.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
> index 46cde0912762..b35923e3a926 100644
> --- a/drivers/acpi/sleep.c
> +++ b/drivers/acpi/sleep.c
> @@ -376,12 +376,10 @@ void __init acpi_sleep_no_blacklist(void)
>
> static void __init acpi_sleep_dmi_check(void)
> {
> - int year;
> -
> if (ignore_blacklist)
> return;
>
> - if (dmi_get_date(DMI_BIOS_DATE, &year, NULL, NULL) && year >= 2012)
> + if (dmi_get_bios_year() >= 2012)
> acpi_nvs_nosave_s3();
>
> dmi_check_system(acpisleep_dmi_table);

Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>

--
Jean Delvare
SUSE L3 Support