Re: [PATCH 1/2] PCI: add vendor id for Altera

[Johannes Thumshirn]

On Tue, 2018-02-27 at 17:32 +0200, Andy Shevchenko wrote:
> On Tue, Feb 27, 2018 at 3:30 PM, Johannes Thumshirn <jthumshirn@xxxxxxx>
> wrote:
> > 
> > Add the Altera PCI Vendor id to pci_ids.h and remove the private
> > definitions from xillybus_pcie.c and altera-cvp.c.
> 
> > 
> > Â#include <linux/pci.h>
> > +#include <linux/pci_ids.h>
> 
> > 
> > Â#include <linux/pci.h>
> > +#include <linux/pci_ids.h>
> 
> Isn't pci.h includes pci_ids.h ?

It indeed is, but it won't do any harm and it's not quite clear what the
general policy (regarding pci_ids.h) is, some drivers include it (even in
the drivers/pci/) some don't.

Bjorn, any guidance from your side?

Byte,
	Johannes

-- 
Johannes Thumshirn                     ÂStorage
jthumshi
rn@xxxxxxx                Â+49 911 74053 689
SUSE LINUX GmbH,
Maxfeldstr. 5, 90409 NÃrnberg
GF: Felix ImendÃrffer, Jane Smithard, Graham
Norton
HRB 21284 (AG NÃrnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600
D0D0 0393 969D 2D76 0850