Re: [PATCH 07/12] i2c: qup: use the complete transfer length to choose DMA mode

From: Andy Gross
Date: Tue Feb 27 2018 - 18:00:02 EST


On Sat, Feb 03, 2018 at 01:28:12PM +0530, Abhishek Sahu wrote:
> Currently each message length in complete transfer is being
> checked for determining DMA mode and if any of the message length
> is less than FIFO length then non DMA mode is being used which
> will increase overhead. DMA can be used for any length and it
> should be determined with complete transfer length. Now, this
> patch introduces DMA threshold length and the transfer will be
> done in DMA mode if the total length is greater than this
> threshold length.
>
> Signed-off-by: Abhishek Sahu <absahu@xxxxxxxxxxxxxx>
> ---

I agree with Sricharan's nit.

Reviewed-by: Andy Gross <andy.gross@xxxxxxxxxx>