Re: [PATCH] drm/sun4i: init dclk_min_div & dclk_max_div inside encoder init functions

From: Maxime Ripard
Date: Wed Feb 28 2018 - 10:56:07 EST


Hi,

On Wed, Feb 28, 2018 at 01:51:58PM +0100, Giulio Benetti wrote:
> sun4i_dclk_round_rate is called before sun4i_tcon_mode_set,
> so it finds dclk_min_div and dclk_max_div set to 0 and fails
> adding crtc.
>
> Move dclk_min_div and dclk_max_div to encoders init functions.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@xxxxxxxxxxxxxxxx>

I sent a similar patch there:
https://lists.freedesktop.org/archives/dri-devel/2018-February/166666.html

I guess eventually, we'll want to remove the usage of the clock
framework entirely, but it's not really the scope of a fix.

Maxime

--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Attachment: signature.asc
Description: PGP signature