Re: [PATCH 1/6] ARM: dts: stm32: Add sdio pins definition for stm32f7

[Patrice CHOTARD]

Hi Alex

On 03/01/2018 10:51 AM, Alexandre Torgue wrote:
> Hi Patrice
> 
> On 03/01/2018 10:43 AM, patrice.chotard@xxxxxx wrote:
>> From: Patrice Chotard <patrice.chotard@xxxxxx>
>>
>> Add sdio pins definition for the 2 sdio instances embeds in stm32f746.
>>
>> Signed-off-by: Patrice Chotard <patrice.chotard@xxxxxx>
>> ---
>> Â arch/arm/boot/dts/stm32f7-pinctrl.dtsi | 62 
>> ++++++++++++++++++++++++++++++++++
>> Â 1 file changed, 62 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/stm32f7-pinctrl.dtsi 
>> b/arch/arm/boot/dts/stm32f7-pinctrl.dtsi
>> index f518de184e52..fb40f0835dd4 100644
>> --- a/arch/arm/boot/dts/stm32f7-pinctrl.dtsi
>> +++ b/arch/arm/boot/dts/stm32f7-pinctrl.dtsi
>> @@ -222,6 +222,68 @@
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ slew-rate = <2>;
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ };
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂ };
>> +
>> +ÂÂÂÂÂÂÂÂÂÂÂ sdio_pins: sdio_pins@0 {
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pins {
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pinmux = <STM32_PINMUX('C', 8, AF12)>, /* SDMMC1 
>> D0 */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ <STM32_PINMUX('C', 9, AF12)>, /* SDMMC1 D1 */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ <STM32_PINMUX('C', 10, AF12)>, /* SDMMC1 D2 */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ <STM32_PINMUX('C', 11, AF12)>, /* SDMMC1 D3 */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ <STM32_PINMUX('C', 12, AF12)>, /* SDMMC1 CLK */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ <STM32_PINMUX('D', 2, AF12)>; /* SDMMC1 CMD */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ drive-push-pull;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ slew-rate = <2>;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ };
>> +ÂÂÂÂÂÂÂÂÂÂÂ };
> 
> if you have 2 pins groups, please use '_a' for the first one. You could 
> have something like:
> 
> sdio_pins_a
> sdio_od_pins_a
> 
> and
> 
> sdio_pins_b
> sdio_od_pins_b

Ok, i prepare a v2

Thanks

Patrice

> 
>> +ÂÂÂÂÂÂÂÂÂÂÂ sdio_pins_od: sdio_pins_od@0 {
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pins1 {
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pinmux = <STM32_PINMUX('C', 8, AF12)>, /* SDMMC1 
>> D0 */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ <STM32_PINMUX('C', 9, AF12)>, /* SDMMC1 D1 */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ <STM32_PINMUX('C', 10, AF12)>, /* SDMMC1 D2 */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ <STM32_PINMUX('C', 11, AF12)>, /* SDMMC1 D3 */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ <STM32_PINMUX('C', 12, AF12)>; /* SDMMC1 CLK */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ drive-push-pull;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ slew-rate = <2>;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ };
>> +
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pins2 {
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pinmux = <STM32_PINMUX('D', 2, AF12)>; /* SDMMC1 
>> CMD */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ drive-open-drain;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ slew-rate = <2>;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ };
>> +ÂÂÂÂÂÂÂÂÂÂÂ };
>> +
>> +ÂÂÂÂÂÂÂÂÂÂÂ sdio_pins_b: sdio_pins_b@0 {
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pins {
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pinmux = <STM32_PINMUX('G', 9, AF11)>, /* SDMMC2 
>> D0 */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ <STM32_PINMUX('G', 10, AF11)>, /* SDMMC2 D1 */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ <STM32_PINMUX('B', 3, AF10)>, /* SDMMC2 D2 */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ <STM32_PINMUX('B', 4, AF10)>, /* SDMMC2 D3 */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ <STM32_PINMUX('D', 6, AF11)>, /* SDMMC2 CLK */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ <STM32_PINMUX('D', 7, AF11)>; /* SDMMC2 CMD */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ drive-push-pull;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ slew-rate = <2>;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ };
>> +ÂÂÂÂÂÂÂÂÂÂÂ };
>> +
>> +ÂÂÂÂÂÂÂÂÂÂÂ sdio_pins_od_b: sdio_pins_od_b@0 {
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pins1 {
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pinmux = <STM32_PINMUX('G', 9, AF11)>, /* SDMMC2 
>> D0 */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ <STM32_PINMUX('G', 10, AF11)>, /* SDMMC2 D1 */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ <STM32_PINMUX('B', 3, AF10)>, /* SDMMC2 D2 */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ <STM32_PINMUX('B', 4, AF10)>, /* SDMMC2 D3 */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ <STM32_PINMUX('D', 6, AF11)>; /* SDMMC2 CLK */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ drive-push-pull;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ slew-rate = <2>;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ };
>> +
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pins2 {
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pinmux = <STM32_PINMUX('D', 7, AF11)>; /* SDMMC2 
>> CMD */
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ drive-open-drain;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ slew-rate = <2>;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ };
>> +ÂÂÂÂÂÂÂÂÂÂÂ };
>> ÂÂÂÂÂÂÂÂÂ };
>> ÂÂÂÂÂ };
>> Â };
>>