Re: [PATCH] tools/gpio/gpio-event-mon: fix warning

From: Linus Walleij
Date: Thu Mar 01 2018 - 09:27:53 EST


On Wed, Feb 21, 2018 at 10:33 PM, Anders Roxell
<anders.roxell@xxxxxxxxxx> wrote:

> PRIu64 is defined in user space to match libc's uint64_t definition.
> However, gpioevent_data structure in the kernel is defined using the
> kernel's own __u64 type.
>
> gpio-event-mon.c: In function âmonitor_deviceâ:
> gpio-event-mon.c:102:19: warning: format â%luâ expects argument of type
> âlong unsigned intâ, but argument 3 has type â__u64 {aka long long
> unsigned int}â [-Wformat=]
> fprintf(stdout, "GPIO EVENT %" PRIu64 ": ", event.timestamp);
> ^~~~~~~~~~~~~~
> LD /tmp/kselftest/gpiogpio-event-mon-in.o
> LINK /tmp/kselftest/gpiogpio-event-mon
>
> Fix is to replace PRIu64 with llu, which we know is what the kernel uses
> for __u64.
>
> Signed-off-by: Anders Roxell <anders.roxell@xxxxxxxxxx>

Patch applied with Daniel's test tag.

Yours,
Linus Walleij