Re: [PATCH 8/9] ASoC: Intel: bytcr_rt5640: Drop unwanted ignore_suspend settings

From: Hans de Goede
Date: Thu Mar 01 2018 - 11:26:29 EST


Hi,

On 01-03-18 17:22, Mark Brown wrote:
On Sun, Feb 18, 2018 at 11:01:45PM +0100, Hans de Goede wrote:
The ignore_suspend settings were added in an attempt to try and fix
suspend / resume issues. But they never fully fixed these and now we've
a proper fix, so lets remove these.

Do these systems not have the ability to continue to play audio through
suspend using the DSP? That's the sort of thing that ignore_suspend is
normally used for.

In theory yes, in practice if we keep ignore_suspend set then we get
audio for a couple of more seconds after suspend until the buffers
are empty, as we have no code keeping them filled, which is not really
useful, since we don't support this in a meaningful way it is better
to just do a normal full suspend.

Regards,

Hans