Re: [PATCH v2 1/8] dt-bindings: scsi: hisi_sas: add an property of signal attenuation

[John Garry]

On 02/03/2018 15:57, Rob Herring wrote:
> On Fri, Mar 2, 2018 at 9:06 AM, John Garry <john.garry@xxxxxxxxxx> wrote:
> > > From: Xiaofei Tan <tanxiaofei@xxxxxxxxxx>
> > >
> > > For some new boards with hip07 chipset we are required to
> > > set PHY config registers differently. The hw property which
> > > determines how to set these registers is in the PHY signal
> > > attenuation readings.
> > >
> > > This patch add an devicetree property, hisi-signal-attenuation,
> > > which is used to describe the signal attenuation of an board.
> > >
> > > Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> > > Cc: Mark Rutland <mark.rutland@xxxxxxx>
> > > Signed-off-by: Xiaofei Tan <tanxiaofei@xxxxxxxxxx>
> > > Signed-off-by: John Garry <john.garry@xxxxxxxxxx>
> > > ---
> > >  Documentation/devicetree/bindings/scsi/hisilicon-sas.txt | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt b/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt
> > > index df3bef7..6f6876a 100644
> > > --- a/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt
> > > +++ b/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt
> > > @@ -53,6 +53,13 @@ Main node required properties:
> > >  Optional main node properties:
> > >   - hip06-sas-v2-quirk-amt : when set, indicates that the v2 controller has the
> > >                             "am-max-transmissions" limitation.
> > > + - hisi-signal-attenuation : array of 3 32-bit values, containing de-emphasis,
> The format for vendor prefixes is: <vendor prefix>,property-name
>
> And should only be ones defined in vendor-prefixes.txt

Hi Rob,

To save a v4, that would be "hisilicon,signal-attenuation", right?

Thanks,
John

> > > +               preshoot, and boost attenuation readings for the board. They
> > > +               are used to describe the signal attenuation of the board. These