Re: [PATCH v2] mmc: Export host capabilities to debugfs.

[Shawn Lin]

On 2018/3/5 12:24, Harish Jenny K N wrote:
> From: Abbas Raza <Abbas_Raza@xxxxxxxxxx>
>
> This patch exports the host capabilities to debugfs
>
> Signed-off-by: Abbas Raza <Abbas_Raza@xxxxxxxxxx>
> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@xxxxxxxxxx>
> Signed-off-by: Harish Jenny K N <harish_kandiga@xxxxxxxxxx>
> ---
>
> Changes in v2:
> - Changed Author
>
>   drivers/mmc/core/debugfs.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c
> index c51e0c0..fa2df7f 100644
> --- a/drivers/mmc/core/debugfs.c
> +++ b/drivers/mmc/core/debugfs.c
> @@ -289,6 +289,9 @@ void mmc_add_card_debugfs(struct mmc_card *card)
>   
>   	card->debugfs_root = root;
>   
> +	if (!debugfs_create_x32("host_caps", S_IRUSR, root, (u32 *)&host->caps))

Perhaps you don't need cast, and '&host->caps' should be fine?
And you don't need to export host->caps2?

> +		goto err;
> +
>   	if (!debugfs_create_x32("state", S_IRUSR, root, &card->state))
>   		goto err;
>