Re: [PATCH 2/3] mfd: rave-sp: Convert print_hex_dump() to print_hex_dump_debug()

[Lucas Stach]

Am Montag, den 26.02.2018, 07:07 -0800 schrieb Andrey Smirnov:
> Convert print_hex_dump() to print_hex_dump_debug() to be able to
> leverage CONFIG_DYNAMIC_DEBUG.
> 
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: cphealy@xxxxxxxxx
> Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>

Reviewed-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>

> ---
> Âdrivers/mfd/rave-sp.c | 8 ++++----
> Â1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mfd/rave-sp.c b/drivers/mfd/rave-sp.c
> index 9e4c83ff2aec..cec1e309b31f 100644
> --- a/drivers/mfd/rave-sp.c
> +++ b/drivers/mfd/rave-sp.c
> @@ -311,8 +311,8 @@ static int rave_sp_write(struct rave_sp *sp,
> const u8 *data, u8 data_size)
> Â
> Â	length = dest - frame;
> Â
> -	print_hex_dump(KERN_DEBUG, "rave-sp tx: ", DUMP_PREFIX_NONE,
> -		ÂÂÂÂÂÂÂ16, 1, frame, length, false);
> +	print_hex_dump_debug("rave-sp tx: ", DUMP_PREFIX_NONE,
> +			ÂÂÂÂÂ16, 1, frame, length, false);
> Â
> Â	return serdev_device_write(sp->serdev, frame, length, HZ);
> Â}
> @@ -453,8 +453,8 @@ static void rave_sp_receive_frame(struct rave_sp
> *sp,
> Â	struct device *devÂÂÂÂÂÂÂÂÂÂÂ= &sp->serdev->dev;
> Â	u8 crc_calculated[checksum_length];
> Â
> -	print_hex_dump(KERN_DEBUG, "rave-sp rx: ", DUMP_PREFIX_NONE,
> -		ÂÂÂÂÂÂÂ16, 1, data, length, false);
> +	print_hex_dump_debug("rave-sp rx: ", DUMP_PREFIX_NONE,
> +			ÂÂÂÂÂ16, 1, data, length, false);
> Â
> Â	if (unlikely(length <= checksum_length)) {
> Â		dev_warn(dev, "Dropping short frame\n");