Re: [PATCH] net: dsa: mv88e6xxx: fix boolreturn.cocci warnings

From: Andrew Lunn
Date: Tue Mar 06 2018 - 11:02:15 EST


On Tue, Mar 06, 2018 at 11:54:07PM +0800, kbuild test robot wrote:
> From: Fengguang Wu <fengguang.wu@xxxxxxxxx>
>
> drivers/net/dsa/mv88e6xxx/serdes.c:66:9-10: WARNING: return of 0/1 in function 'mv88e6352_port_has_serdes' with return type bool
>
> Return statements in functions returning bool should use
> true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> Fixes: eb755c3f6b7d ("net: dsa: mv88e6xxx: Add helper to determining if port has SERDES")
> CC: Andrew Lunn <andrew@xxxxxxx>
> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew