Re: [PATCH v4 1/3] Input: gpio-keys - add support for wakeup event action

[Andy Shevchenko]

On Tue, Mar 6, 2018 at 9:44 AM, Jeffy Chen <jeffy.chen@xxxxxxxxxxxxxx> wrote:
> Add support for specifying event actions to trigger wakeup when using
> the gpio-keys input device as a wakeup source.
>
> This would allow the device to configure when to wakeup the system. For
> example a gpio-keys input device for pen insert, may only want to wakeup
> the system when ejecting the pen.

> +       bool wakeup_enabled;

> +                       if (bdata->wakeup_enabled) {

This is redundant. IRQ core keeps track on this information already.

Check below as an example
aef3ad103a68 ("serial: core: remove unneeded irq_wake flag")


-- 
With Best Regards,
Andy Shevchenko