Re: [PATCH v3 1/2] mfd: arizona: Update reset pin to use GPIOD

[Fabio Estevam]

On Wed, Mar 7, 2018 at 11:55 AM, Charles Keepax
<ckeepax@xxxxxxxxxxxxxxxxxxxxx> wrote:

> Hmm... this raises a rather good point that I hadn't considered.
> This driver is used in a lot of shipping devices and the old
> style GPIO calls didn't take the activeness of the GPIO into
> account just blindly setting the value you asked for. However the
> new style calls do take this into account.
>
> The trouble is I guess we don't know whether most users bothered
> to set GPIO_ACTIVE_LOW or not. So it is very hard to say here if
> we are about to breaking a lot of existing device trees here.
>
> I guess probably the safest approach is to use
> gpiod_set_raw_value_cansleep here?

Yes, probably needed to avoid breakage of existing systems.