Re: [PATCH] vsprintf: Remove accidental VLA usage

From: Kees Cook
Date: Wed Mar 07 2018 - 19:36:26 EST


On Wed, Mar 7, 2018 at 4:03 PM, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, 7 Mar 2018 15:59:27 -0800 Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
>> I didn't want to encourage a global macro that _lacked_ the safety
>> built into the max*() family, though... thoughts for a reasonable
>> approach?
>
> I think SIMPLE_MAX() is OK. Along with one of /* these */ things ;)

Sounds good. I will resend with net/ipv[46]/proc.c and one other fixed
as well...

-Kees

--
Kees Cook
Pixel Security