Re: [PATCH] net: hns: use put_device() if device_register fail

From: David Miller
Date: Mon Mar 12 2018 - 10:43:30 EST


From: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
Date: Fri, 9 Mar 2018 16:11:17 +0530

> if device_register() returned an error! Always use put_device()
> to give up the reference initialized.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>

I do not see anything giving cls_dev an initial non-zero reference
count before this device_register() call.

And I have no idea why you use a "!" when saying 'error' you this
commit log message.