Re: [PATCH v3 00/20] firmware: development for v4.17

From: Greg KH
Date: Wed Mar 14 2018 - 13:58:32 EST


On Wed, Mar 14, 2018 at 05:44:03PM +0000, Luis R. Rodriguez wrote:
> On Sat, Mar 10, 2018 at 09:16:36AM -0800, Kees Cook wrote:
> > On Sat, Mar 10, 2018 at 6:14 AM, Luis R. Rodriguez <mcgrof@xxxxxxxxxx> wrote:
> > > Greg,
> > >
> > > Here's a respin of what I have queued up for v4.17 for the firmware API. It
> > > combines the cleanup I've been working on and the addition of the new API call
> > > request_firmware_cache() for fixing a corner case suspend issue on some type of
> > > cards with an optimization in place where the firmware is *not* needed on
> > > reboot.
> > >
> > > The cleanup work allows us to test the firmware API with one kernel
> > > configuration. I've addressed Kees' feedback on this respin and
> > > combined the code into drivers/base/firmware_class/.
> > >
> > > I've made one new test_firmware change in consideration for one firmware
> > > change, the patch "firmware: ensure the firmware cache is not used on
> > > incompatible calls" requires us to modify our tests scripts to use
> > > the APIs sanely as well.
> > >
> > > I've put up these changes on my git tree, refer to the branch
> > > "20180307-firmware-dev-for-v4.17" based on linux-next [0] and
> > > the same name based on Linus' tree [1].
> > >
> > > Questions, feedback, and specially rants are always welcomed.
> >
> > This all looks good to me! Thanks for respinning. :)
>
> Greg,
>
> I'd like to get these baked a bit through linux-next. Let me know if its
> easier for you if I go through Andrew for the firmware API changes.

I'm just about to queue up all of the firmware patches right now, so no
need to bother Andrew :)

thanks,

greg k-h