Re: [PATCH v2 00/36] remove in-kernel syscall invocations (part 1)

From: Christoph Hellwig
Date: Fri Mar 16 2018 - 04:54:32 EST


On Thu, Mar 15, 2018 at 05:54:27PM -0700, Linus Torvalds wrote:
> Yes. And honestly, I'd rather have these kinds of "just change the
> calling convention" almost automated patches separately - and then the
> cleanups later.
>
> Mixing the calling convention change and the cleanup together is just
> confusing and potentially causes subtle issues.

A lot of the issues here is that the initramfs / do_mount code
is written as if it was user space code, but in kernel space. E.g.
using file desriptors etc. I think doing one or a few patches
before this series to sort this out would really reduce the scope
of work and be the right thing. For any additional minor cleanups
I agree that it might make sense to postpone them.