Re: [PATCH v4 0/5] PCI endpoint 64-bit BAR fixes

From: Niklas Cassel
Date: Wed Mar 21 2018 - 00:10:09 EST


On Mon, Mar 19, 2018 at 04:52:34PM +0000, Lorenzo Pieralisi wrote:
> On Thu, Mar 08, 2018 at 02:33:25PM +0100, Niklas Cassel wrote:
> > PCI endpoint fixes to improve the way 64-bit BARs are handled.
> >
> >
> > There are still future improvements that could be made:
> >
> > pci-epf-test.c always allocates space for
> > 6 BARs, even when using 64-bit BARs (which
> > really only requires us to allocate 3 BARs).
> >
> > pcitest.sh will print "NOT OKAY" for BAR1,
> > BAR3, and BAR5 when using 64-bit BARs.
> > This could probably be improved to say
> > something like "N/A (64-bit BAR)".
> >
> > Niklas Cassel (5):
> > PCI: endpoint: BAR width should not depend on sizeof dma_addr_t
> > PCI: designware-ep: Make dw_pcie_ep_set_bar() handle 64-bit BARs
> > properly
> > PCI: designware-ep: Make dw_pcie_ep_reset_bar() handle 64-bit BARs
> > properly
> > PCI: endpoint: Make pci_epc_set_bar() return the BAR width that was
> > set-up
> > misc: pci_endpoint_test: Handle 64-bit BARs properly
> >
> > drivers/misc/pci_endpoint_test.c | 12 +++++++-----
> > drivers/pci/cadence/pcie-cadence-ep.c | 2 +-
> > drivers/pci/dwc/pcie-designware-ep.c | 22 ++++++++++++++++++----
> > drivers/pci/endpoint/functions/pci-epf-test.c | 22 +++++++++++++++-------
> > 4 files changed, 41 insertions(+), 17 deletions(-)
>
> Niklas,
>
> I am fine with the series but I'd need Kishon ACKs (and Greg's for the
> last patch), I am ready to queue them then.


Hello Kishon,

could you please have a look at this series?


Kind regards,
Niklas