Re: [PATCH V3] ZBOOT: fix stack protector in compressed boot phase

From: James Hogan
Date: Fri Mar 23 2018 - 17:08:24 EST


On Fri, Mar 23, 2018 at 11:50:55AM +0800, Jiaxun Yang wrote:
> å 2018-03-22åç 22:21 +0000ïJames Hoganåéï
> > Also I think it worth mentioning in the commit message the MIPS
> > configuration you hit this with, presumably a Loongson one? For me
> > decompress_kernel() gets a stack guard on loongson3_defconfig, but
> > not
> > malta_defconfig or malta_defconfig + 64-bit. I presume its sensitive
> > to
> > the compiler inlining stuff into decompress_kernel() or something
> > such
> > that it suddenly qualifies for a stack guard.
>
> Have you tested with CONFIG_CC_STACKPROTECTOR_STRONG=y ?

Yes. for malta_defconfig I could only reproduce by adding an array to
decompress_kernel() so that it would get the guard.

Cheers
James

Attachment: signature.asc
Description: Digital signature