Re: [PATCH v2 0/2] Fix __earlycon_table stride... again

From: Daniel Kurtz
Date: Sat Mar 24 2018 - 00:49:57 EST


On Fri, Mar 23, 2018 at 7:34 AM Greg Kroah-Hartman <
gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

> On Tue, Mar 20, 2018 at 11:57:10AM -0600, Daniel Kurtz wrote:
> > The __earlycon_table lives in a special "__earlycon_table" section. The
> > contents of this table are added using some macros that deposit
individual
> > struct earlycon_id entries into this section. The linker then defines
a symbol
> > __earlycon_table that is supposed to contain the addresss of the first
of these
> > entries. The code in earlycon.c and fdt.c then tries to access the
memory
> > pointed to by __earlycon_table as an array of struct earlycon_id
entries.
> >
> > Unfortunately, the compiler doesn't always place the entries such that
they
> > are an array. Let's fix that.
> >
> > Patch 1 of the series is a fix that should hopefully fix a kbuild error
that
> > seems to be triggered by Patch 2.

> Doesn't seem like that worked :(

> And I have a bunch of different versions of this patch in my to-review
> queue, and I can't figure out which is the "latest" one.

> Can you resend it, after getting the build error fixed, so I know which
> to attempt to apply?

Please take Patch Set v5 (fixes kbuild errors and commit message typos):
https://patchwork.kernel.org/patch/10298043/

thanks,
-djk


> thanks,

> greg k-h