RE: [RFC PATCH net-next] tipc: tipc_disc_addr_trial_msg() can be static

[Jon Maloy]

Acked-by: Jon Maloy jon.maloy@xxxxxxxxxxxx

Thanks, Fengguang

> -----Original Message-----
> From: netdev-owner@xxxxxxxxxxxxxxx [mailto:netdev-
> owner@xxxxxxxxxxxxxxx] On Behalf Of kbuild test robot
> Sent: Friday, March 23, 2018 15:48
> To: Jon Maloy <jon.maloy@xxxxxxxxxxxx>
> Cc: kbuild-all@xxxxxx; netdev@xxxxxxxxxxxxxxx; Ying Xue
> <ying.xue@xxxxxxxxxxxxx>; tipc-discussion@xxxxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: [RFC PATCH net-next] tipc: tipc_disc_addr_trial_msg() can be static
> 
> 
> Fixes: 25b0b9c4e835 ("tipc: handle collisions of 32-bit node address hash
> values")
> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> ---
>  discover.c |   14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/net/tipc/discover.c b/net/tipc/discover.c index e765573..9f666e0
> 100644
> --- a/net/tipc/discover.c
> +++ b/net/tipc/discover.c
> @@ -134,13 +134,13 @@ static void disc_dupl_alert(struct tipc_bearer *b,
> u32 node_addr,
> 
>  /* tipc_disc_addr_trial(): - handle an address uniqueness trial from peer
>   */
> -bool tipc_disc_addr_trial_msg(struct tipc_discoverer *d,
> -			      struct tipc_media_addr *maddr,
> -			      struct tipc_bearer *b,
> -			      u32 dst, u32 src,
> -			      u32 sugg_addr,
> -			      u8 *peer_id,
> -			      int mtyp)
> +static bool tipc_disc_addr_trial_msg(struct tipc_discoverer *d,
> +				     struct tipc_media_addr *maddr,
> +				     struct tipc_bearer *b,
> +				     u32 dst, u32 src,
> +				     u32 sugg_addr,
> +				     u8 *peer_id,
> +				     int mtyp)
>  {
>  	struct net *net = d->net;
>  	struct tipc_net *tn = tipc_net(net);