Re: [bug, bisected] pfifo_fast causes packet reordering

From: John Fastabend
Date: Sat Mar 24 2018 - 10:26:48 EST


On 03/22/2018 03:16 AM, Jakob Unterwurzacher wrote:
> On 21.03.18 21:52, John Fastabend wrote:
>> Can you try this,
>>
>> diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
>> index d4907b5..1e596bd 100644
>> --- a/include/net/sch_generic.h
>> +++ b/include/net/sch_generic.h
>> @@ -30,6 +30,7 @@ struct qdisc_rate_table {
>> Â enum qdisc_state_t {
>> ÂÂÂÂÂÂÂÂ __QDISC_STATE_SCHED,
>> ÂÂÂÂÂÂÂÂ __QDISC_STATE_DEACTIVATED,
>> +ÂÂÂÂÂÂ __QDISC_STATE_RUNNING,
>> Â };
>> [...]
>
> Tested, looks good. No OOO observed, no side effects observed, iperf
> numbers on Gigabit Ethernet look the same.
>
> Thanks,
> Jakob

Thanks, I'll send out an official patch today.

.John