Re: [RFC v2 01/12] KVM: arm/arm64: Set dist->spis to NULL after kfree

From: Auger Eric
Date: Wed Mar 28 2018 - 02:41:36 EST


Hi Marc,
On 27/03/18 19:10, Marc Zyngier wrote:
> On 27/03/18 15:04, Eric Auger wrote:
>> in case kvm_vgic_map_resources() fails, typically if the vgic
>> distributor is not defined, __kvm_vgic_destroy will be called
>> several times. Indeed kvm_vgic_map_resources() is called on
>> first vcpu run. As a result dist->spis is freeed more than once
>> and on the second time it causes a "kernel BUG at mm/slub.c:3912!"
>>
>> Set dist->spis to NULL to avoid the crash.
>>
>> Signed-off-by: Eric Auger <eric.auger@xxxxxxxxxx>
>
> Fixes: ad275b8bb1e6 ("KVM: arm/arm64: vgic-new: vgic_init: implement
> vgic_init")
Sorry for the oversight :-(
>
> Reviewed-by: Marc Zyngier <marc.zyngier@xxxxxxx>
Thanks

Eric
>
> M.
>