Re: [PATCH 1/3] virt: vbox: Add vbg_req_free() helper function

[Hans de Goede]

Hi,

On 29-03-18 13:55, Greg Kroah-Hartman wrote:
> On Thu, Mar 29, 2018 at 01:21:14PM +0200, Hans de Goede wrote:
> > --- a/include/linux/vbox_utils.h
> > +++ b/include/linux/vbox_utils.h
> > @@ -33,6 +33,13 @@ __printf(1, 2) void vbg_debug(const char *fmt, ...);
> >    */
> >   void *vbg_req_alloc(size_t len, enum vmmdev_request_type req_type);
> >   
> > +/**
> > + * Free a request allocated by vbg_req_alloc()
> > + * @req:		Request to free.
> > + * @len:		Length, must be the same as the value used for alloc.
> > + */
> > +void vbg_req_free(void *req, size_t len);
> > +
>
> Why is this in vbox_utils.h and not exported?  Shouldn't you just put
> this in drivers/virt/vboxguest/vboxguest_core.h?

I put it in include/linux/vbox_utils.h because that is where its
counterpart vbg_req_alloc() lives. But you're right that neither
is used outside of the vboxguest module, so I will move vbg_req_alloc()
to vboxguest_core.h for v2 and also put the new vbg_req_free() there.

Regards,

Hans