Re: [PATCH 15/19] powerpc: Add missing prototype

[LEROY Christophe]

Mathieu Malaterre <malat@xxxxxxxxxx> a ÃcritÂ:

> On Fri, Mar 23, 2018 at 1:20 PM, christophe leroy
> <christophe.leroy@xxxxxx> wrote:
> > Le 22/03/2018 Ã 21:20, Mathieu Malaterre a Ãcrit :
> > > Add one missing prototype for function rh_dump_blk. Fix warning treated as
> > > error in W=1:
> > >
> > >    arch/powerpc/lib/rheap.c:740:6: error: no previous prototype for
> > > ârh_dump_blkâ [-Werror=missing-prototypes]
> > >
> > > Signed-off-by: Mathieu Malaterre <malat@xxxxxxxxxx>
> > > ---
> > >   arch/powerpc/include/asm/rheap.h | 3 +++
> > >   1 file changed, 3 insertions(+)
> > >
> > > diff --git a/arch/powerpc/include/asm/rheap.h
> > > b/arch/powerpc/include/asm/rheap.h
> > > index 172381769cfc..e75d96de19a0 100644
> > > --- a/arch/powerpc/include/asm/rheap.h
> > > +++ b/arch/powerpc/include/asm/rheap.h
> > > @@ -83,6 +83,9 @@ extern int rh_get_stats(rh_info_t * info, int what, int
> > > max_stats,
> > >   /* Simple dump of remote heap info */
> > >   extern void rh_dump(rh_info_t * info);
> > >   +/* Simple dump of remote info block */
> > > +extern void rh_dump_blk(rh_info_t *info, rh_block_t *blk);
> > > +
> >
> >
> > Only used in one place, should be static
>
> Well here is what I see over here:
>
> $ git grep rh_dump_blk
> ...
> arch/powerpc/lib/rheap.c:EXPORT_SYMBOL_GPL(rh_dump_blk);

If it was really used by anybody in a module, it would already be in a  
.h so I think we should simply delete the function

Christophe

> > Christophe
> >
> > >   /* Set owner of taken block */
> > >   extern int rh_set_owner(rh_info_t * info, unsigned long start, const
> > > char *owner);
> >
> >
> > ---
> > L'absence de virus dans ce courrier Ãlectronique a Ãtà vÃrifiÃe par le
> > logiciel antivirus Avast.
> > https://www.avast.com/antivirus