Re: [PATCH 3/4] nvmet-fc: Don't use the count returned by the dma_map_sg call

From: Logan Gunthorpe
Date: Thu Mar 29 2018 - 12:30:58 EST




On 29/03/18 10:24 AM, James Smart wrote:
> Signed-off-by: James Smart <james.smart@xxxxxxxxxxxx>

Thanks James.

> As for "not used anywhere", be careful as the structure being prepped is
> passed from the nvme-fc transport to an underlying lldd. So the
> references would likely be in the lldd.

Can you elaborate? The 'data_sg_cnt' member was in 'struct
nvmet_fc_fcp_iod' which is declared in fc.c so it doesn't seem sane for
lower driver to access it... In fact the next patch in the series
removes it completely.

Logan