Re: [RFC PATCH] crypto: brcm - explicitly cast cipher to hash type

From: Herbert Xu
Date: Fri Mar 30 2018 - 13:43:53 EST


On Sat, Mar 24, 2018 at 12:02:42PM +0100, Stefan Agner wrote:
> In the AES cases enum spu_cipher_type and enum hash_type have
> the same values, so the assignment is fine. Explicitly cast
> the enum type conversion.
>
> This fixes two warnings when building with clang:
> drivers/crypto/bcm/cipher.c:821:34: warning: implicit conversion from
> enumeration type 'enum spu_cipher_type' to different enumeration
> type 'enum hash_type' [-Wenum-conversion]
> hash_parms.type = cipher_parms.type;
> ~ ~~~~~~~~~~~~~^~~~
> drivers/crypto/bcm/cipher.c:1412:26: warning: implicit conversion from
> enumeration type 'enum spu_cipher_type' to different enumeration
> type 'enum hash_type' [-Wenum-conversion]
> hash_parms.type = ctx->cipher_type;
> ~ ~~~~~^~~~~~~~~~~
>
> Signed-off-by: Stefan Agner <stefan@xxxxxxxx>

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt