Re: [PATCH 06/12] wireless: Convert simple uses of a static const Ethernet broadcast address

[Pkshih]

On Sat, 2018-03-31 at 00:05 -0700, Joe Perches wrote:
> Use the new ether_broadcast_addr global instead to save some object code.
> 
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
> Âdrivers/net/wireless/admtek/adm8211.cÂÂÂÂÂÂÂÂÂÂÂ| 3 +--
> Âdrivers/net/wireless/ath/carl9170/mac.cÂÂÂÂÂÂÂÂÂ| 4 +---
> Âdrivers/net/wireless/broadcom/b43/main.cÂÂÂÂÂÂÂÂ| 3 +--
> Âdrivers/net/wireless/marvell/mwifiex/cfg80211.c | 3 +--
> Âdrivers/net/wireless/realtek/rtlwifi/core.cÂÂÂÂÂ| 5 ++---
> Âdrivers/net/wireless/rndis_wlan.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ| 6 +-----
> Âdrivers/net/wireless/ti/wl1251/main.cÂÂÂÂÂÂÂÂÂÂÂ| 5 +----
> Âdrivers/net/wireless/ti/wlcore/main.cÂÂÂÂÂÂÂÂÂÂÂ| 5 +----
> Â8 files changed, 9 insertions(+), 25 deletions(-)
> 
> Â
> diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c
> b/drivers/net/wireless/realtek/rtlwifi/core.c
> index cfea57efa7f4..8c534a93dad5 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/core.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/core.c
> @@ -1527,7 +1527,6 @@ static int rtl_op_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
> Â	bool wep_only = false;
> Â	int err = 0;
> Â	u8 mac_addr[ETH_ALEN];
> -	u8 bcast_addr[ETH_ALEN] = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff };
> Â
> Â	rtlpriv->btcoexist.btc_info.in_4way = false;
> Â
> @@ -1544,7 +1543,7 @@ static int rtl_op_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
> Â	RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
> Â		Â"%s hardware based encryption for keyidx: %d, mac: %pM\n",
> Â		ÂÂcmd == SET_KEY ? "Using" : "Disabling", key->keyidx,
> -		ÂÂsta ? sta->addr : bcast_addr);
> +		ÂÂsta ? sta->addr : ether_broadcast_addr);
> Â	rtlpriv->sec.being_setkey = true;
> Â	rtl_ips_nic_on(hw);
> Â	mutex_lock(&rtlpriv->locks.conf_mutex);
> @@ -1649,7 +1648,7 @@ static int rtl_op_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
> Â			memcpy(rtlpriv->sec.key_buf[key_idx],
> Â			ÂÂÂÂÂÂÂkey->key, key->keylen);
> Â			rtlpriv->sec.key_len[key_idx] = key->keylen;
> -			memcpy(mac_addr, bcast_addr, ETH_ALEN);
> +			memcpy(mac_addr, ether_broadcast_addr, ETH_ALEN);

UseÂether_addr_copy(mac_addr, ether_broadcast_addr) ?


> Â		} else {	/* pairwise key */
> Â			RT_TRACE(rtlpriv, COMP_SEC, DBG_DMESG,
> Â				Â"set pairwise key\n");