Re: [PATCH v8 42/42] ARM: dts: da850: Add clocks

[David Lechner]

On 04/02/2018 06:12 AM, Sekhar Nori wrote:
> On Friday 16 March 2018 10:50 PM, David Lechner wrote:
> > On 03/15/2018 09:52 PM, David Lechner wrote:
> > > This adds clock provider nodes for da850 and wires them up to all of the
> > > devices.
> > >
> > > Signed-off-by: David Lechner <david@xxxxxxxxxxxxxx>
> > > ---
> >
> > ...
> >
> > This is the mcasp0: mcasp@100000 node...
> >
> > > @@ -560,6 +720,7 @@
> > >  ÂÂÂÂÂÂÂÂÂÂÂÂÂ dmas = <&edma0 1 1>,
> > >  ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ <&edma0 0 1>;
> > >  ÂÂÂÂÂÂÂÂÂÂÂÂÂ dma-names = "tx", "rx";
> > > +ÂÂÂÂÂÂÂÂÂÂÂ clocks = <&psc1 7>;
> >
> > After some testing, it looks like it needs to be:
> >
> > +ÂÂÂÂÂÂÂÂÂÂÂ power-domains = <&psc1 7>;
> >
> > instead of
> >
> > +ÂÂÂÂÂÂÂÂÂÂÂ clocks = <&psc1 7>;
>
> We should probably have both clocks and power-domains properties for all
> PSC clocks. This way, the driver can change without a corresponding DT
> update dependency.
>
> Thanks,
> Sekhar

That's fine with me. I just didn't know how people felt about using properties
that are not documented.