Re: [PATCH 4.4 70/97] rtc: ds1374: wdt: Fix issue with timeout scaling from secs to wdt ticks

From: Ben Hutchings
Date: Tue Apr 03 2018 - 17:46:34 EST


On Fri, 2018-03-23 at 10:54 +0100, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.ÂÂIf anyone has any objections, please let me know.
>
> ------------------
>
> From: Moritz Fischer <mdf@xxxxxxxxxx>
>
>
> [ Upstream commit 453d0744f6c6ca3f9749b8c57c2e85b5b9f52514 ]
>
> The issue is that the internal counter that triggers the watchdog reset
> is actually running at 4096 Hz instead of 1Hz, therefore the value
> given by userland (in sec) needs to be multiplied by 4096 to get the
> correct behavior.
[...]

The wdt_margin module parameter has the same problem.

Ben.

--
Ben Hutchings
Software Developer, Codethink Ltd.