Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

From: gregkh
Date: Thu Apr 05 2018 - 08:30:25 EST

On Thu, Apr 05, 2018 at 10:30:01AM +0000, Laurentiu Tudor wrote:
> Hello,
> My 2c below.
> On 04/04/2018 03:42 PM, Andrew Lunn wrote:
> >> I hear you. It is more complicated this way...having all these individual
> >> objects vs just a single "bundle" of them that represents a NIC. But, that's
> >> the way the DPAA2 hardware is, and we're implementing kernel support for
> >> the hardware as it is.
> >
> > Hi Stuart
> >
> > I see we are not making any progress here.
> >
> > So what i suggest is you post the kernel code and configuration tool
> > concept to netdev for a full review. You want reviews from David
> > Miller, Jiri Pirko, Jakub Kicinski, David Ahern, etc.
> >
> I think that the discussion steered too much towards networking related
> topics, while this ioctl doesn't have much to do with networking.
> It's just an ioctl for our mc-bus bus driver that is used to manage the
> devices on this bus through userspace tools.
> In addition, I'd drop any mention of our reference user space app
> (restool) to emphasize that this ioctl is not added just for a
> particular user space app. I think Stuart also mentioned this.

I'm not going to take a "generic device configuration ioctl" patch
unless it is documented to all exactly what it does, and why it is


greg k-h