Re: [PATCH v7] kernel.h: Retain constant expression output for max()/min()

From: Kees Cook
Date: Thu Apr 05 2018 - 18:10:22 EST

On Thu, Apr 5, 2018 at 2:20 PM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Apr 5, 2018 at 1:42 PM, Linus Torvalds
> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>> Ok, applied.
> Ugh, during the merge window, we had actually grown a new example of
> that "different enum types" problem:
> struct drm_prop_enum_list enum_list[max(DRM_COLOR_ENCODING_MAX,
> in drm_plane_create_color_properties() in the drm drm_color_mgmt.c file.
> I ended up just fixing it up manually and added it to the commit. You
> should double-check my change, I've pushed it out now that the build
> seems ok for me.

Looks good; thanks!

> There may be others hiding that weren't caught by my limited build
> testing, trhough. So please keep an eye out for build warnings.

I'll spin up my full multi-arch allmodconfig builds and see if
anything kicks out...


Kees Cook
Pixel Security