Re: [PATCH v2] dp83640: Ensure against premature access to PHY registers after reset

From: Andrew Lunn
Date: Fri Apr 06 2018 - 13:23:46 EST

On Fri, Apr 06, 2018 at 07:08:44PM +0200, Esben Haabendal wrote:
> From: Esben Haabendal <eha@xxxxxxxx>

Hi Esben

It it good to have some form of commit message. Something like:

The datasheet specifies a 3uS pause after performing a software
reset. The default implementation of genphy_soft_reset() does not
provide this, so implement soft_reset with the needed pause.

With that, or something similar added:

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>