Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

From: Linus Torvalds
Date: Mon Apr 09 2018 - 13:03:09 EST


On Mon, Apr 9, 2018 at 9:18 AM, Sebastian Ott <sebott@xxxxxxxxxxxxx> wrote:
>
> Both of the following return 0 on my machine:
> + pr_warn("%u\n", min_not_zero(100, 1000));
> + pr_warn("%u\n", min_not_zero(1000, 100));

Oooh.

[ Raises hand, and says "I know, I know, pick me, pick me" ]

min_not_zero() hasinternal variables "__x" and "__y".

And "__cmp_once()" has internal variables "__x" and "__y".

When min_not_zero does

min(__x, __y));

that expands to crazy stuff.

Out old "min()" had the internal variables called "min1" and "min2",
which is crazy too.

Linus