Re: [PATCH] uapi/linux/keyctl.h: don't use C++ reserved keyword as a struct member name

From: David Howells
Date: Tue Apr 10 2018 - 04:47:09 EST


Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:

> Since this header is in "include/uapi/linux/", apparently people
> want to use it in userspace programs -- even in C++ ones.
> However, the header uses a C++ reserved keyword ("private"),
> so change that to "dh_private" instead to allow the header file
> to be used in C++ userspace.
>
> Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=191051

Ugh. Yeah. This is a UAPI breaker, but I think we have to do it, despite it
being 2 years old. Maybe wrap that element in a #ifdef so it's still allowed
in C?

cc'ing Mat Martineau as he's the originator of the structure.

David