Re: [PATCH] tools: restore READ_ONCE() C++ compatibility

From: Mark Rutland
Date: Tue Apr 10 2018 - 06:55:25 EST


On Mon, Apr 09, 2018 at 04:40:32PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Apr 09, 2018 at 06:10:41PM +0100, Mark Rutland escreveu:
> > Hi Arnaldo,
> >
> > As Sandipan gave a Tested-by for this, are you happy to pick it up as a
> > fix for v4.17?
> >
> > Or would you prefer that I resend this?
>
> I forgot about this fix, but was exposed to it while processing
> Sandipan's patches for fixing up builtin clang support, so I ended up
> adding the following patch:
>
> https://git.kernel.org/acme/c/ad0902e0c400
>
> This sidesteps this issue by removing the sequence of includes that ends
> up including the compiler.h from a C++ file.
>
> Now 'make LIBCLANGLLVM=1 -C tools/perf' works, but I'll look at the
> patch below, probably it will save some time in the future if we get to
> include compiler.h from C++ code again...
>
> Take a look at my perf/urgent branch, that I just asked Ingo to pull.

Ah, that's great.

Sorry for the noise!

Mark.