Re: [PATCH v2] X86/VMX: Disable VMX preemption timer if MWAIT is not intercepted

From: Raslan, KarimAllah
Date: Tue Apr 10 2018 - 08:17:10 EST


On Tue, 2018-04-10 at 13:07 +0200, Paolo Bonzini wrote:
> On 10/04/2018 12:08, KarimAllah Ahmed wrote:
> >
> > @@ -11908,6 +11908,9 @@ static int vmx_set_hv_timer(struct kvm_vcpu *vcpu, u64 guest_deadline_tsc)
> > u64 guest_tscl = kvm_read_l1_tsc(vcpu, tscl);
> > u64 delta_tsc = max(guest_deadline_tsc, guest_tscl) - guest_tscl;
> >
> > + if (kvm_pause_in_guest(vcpu->kvm))
> > + return -EOPNOTSUPP;
> > +
>
> This is still doing a relatively expensive kvm_read_l1_tsc, so move it
> even further up. :)

hehe .. done in v3 :)

>
> Paolo
>
Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B