Re: [PATCHv2 3/7] sched/fair: Consider misfit tasks when load-balancing

From: Peter Zijlstra
Date: Wed Apr 11 2018 - 06:46:53 EST


On Thu, Mar 15, 2018 at 02:47:00PM +0000, Morten Rasmussen wrote:
> @@ -8548,6 +8569,14 @@ static struct rq *find_busiest_queue(struct lb_env *env,
> if (rt > env->fbq_type)
> continue;
>
> + /*
> + * For ASYM_CPUCAPACITY domains with misfit tasks we ignore
> + * load.
> + */
> + if (env->src_grp_type == group_misfit_task &&
> + rq->misfit_task_load)
> + return rq;
> +
> capacity = capacity_of(i);
>
> wl = weighted_cpuload(rq);

Similarly, should we not return worst misfit instead of the first?