Re: [PATCH v2] blk-cgroup: remove entries in blkg_tree before queue release

From: Tejun Heo
Date: Wed Apr 11 2018 - 10:20:27 EST


Hello,

On Wed, Apr 11, 2018 at 12:12:56PM +0200, Alexandru Moise wrote:
> > But we already do this through calling blkcg_exit_queue() from
> > __blk_release_queue(). What's missing?
>
> Hi,
>
> It might be the jetlag but I can't see how you end up calling
> blkcg_exit_queue() from __blk_release_queue().
>
> As I see it the only way to reach blkcg_exit_queue() is from
> blk_cleanup_queue(), which I don't see anywhere in __blk_release_queue().
>
> I suspect that I'm just fixing a corner case though and
> the general case is what you describe or similar.

Ah, that changed recently. Can you please check out the current
upstream git master?

Thanks.

--
tejun