Re: [PATCH v2] blk-cgroup: remove entries in blkg_tree before queue release

From: tj@xxxxxxxxxx
Date: Wed Apr 11 2018 - 15:57:10 EST


On Wed, Apr 11, 2018 at 01:55:25PM -0600, Bart Van Assche wrote:
> On 04/11/18 13:00, Alexandru Moise wrote:
> >But the root cause of it is in blkcg_init_queue() when blkg_create() returns
> >an ERR ptr, because it tries to insert into a populated index into blkcg->blkg_tree,
> >the entry that we fail to remove at __blk_release_queue().
>
> Hello Alex,
>
> Had you considered something like the untested patch below?

But queue init shouldn't fail here, right?

Thanks.

--
tejun