Re: [PATCH] soc: ti: knav_qmss: Use percpu instead atomic for stats counter

From: santosh.shilimkar@xxxxxxxxxx
Date: Fri Apr 13 2018 - 11:19:38 EST


On 4/11/18 3:28 PM, santosh.shilimkar@xxxxxxxxxx wrote:
On 4/11/18 12:16 PM, Vasyl Gomonovych wrote:
Hwqueue has collect statistics in heavy use queue_pop/queu_push functions
for cache efficiency and make push/pop faster use percpu variables.
For performance reasons, driver should keep descriptor in software handler
as short as possible and quickly return it back to hardware queue.
Descriptors coming into driver from hardware after pop and return back
by push to reduce descriptor lifetime in driver collect statistics on percpu.

Signed-off-by: Vasyl Gomonovych <gomonovych@xxxxxxxxx>
---
This is really good idea. Have you tested this patch ? If not it needs
to be tested on Keystone SOCs to make sure all works.

Thanks for confirming the tests done with rapidIO offlist. Will queue
this patch for next merge window.

Regards,
Santosh