Re: [PATCH v2 3/3] Documentation/i2c: adopt kernel commenting style in examples

From: Sam Hansen
Date: Fri Apr 13 2018 - 13:39:52 EST


On Fri, Apr 13, 2018 at 9:50 AM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
>
>> - int adapter_nr = 2; /* probably dynamically determined */
>
> Such comments are actually OK.

Ah, gotcha. Thanks for the correction. Standby for revised patch set.

>
>> - /* ERROR HANDLING; you can check errno to see what went wrong */
>
> Such as well.
>
>> - /* Using I2C Write, equivalent of
>> - i2c_smbus_write_word_data(file, reg, 0x6543) */
>> + /*
>> + * Using I2C Write, equivalent of
>> + * i2c_smbus_write_word_data(file, reg, 0x6543).
>> + */
>
> This is the only broken one AFAICT.
>