Re: EXT: Re: [PATCHv1] Input: atmel_mxt_ts - fix the firmware update

From: Nandor Han
Date: Tue Apr 17 2018 - 04:28:01 EST

On 23/03/18 21:47, Nick Dyer wrote:
On Thu, Mar 22, 2018 at 05:43:30PM +0100, Sebastian Reichel wrote:
The automatic update mechanism will trigger an update if the
info block CRCs are different between maxtouch configuration
file (maxtouch.cfg) and chip.

The driver compared the CRCs without retrieving the chip CRC,
resulting always in a failure and firmware flashing action
triggered. The patch will fix this issue by retrieving the
chip info block CRC before the check.

Thanks for raising this, I agree it's definitely something we want to

However, I'm not convinced you're solving the problem in the best way.
You've attached it to the read_t9_resolution() code path, whereas the
info block is common between T9 and T100 and works in the same way.

Would you mind trying the below patch? I've dusted it off from some
work that I did back in 2012 and it should solve your issue.

It also has the benefit that by reading the information block and the
object table into a contiguous region of memory, we can verify the
checksum at probe time. This means we make sure that we are indeed
talking to a chip that supports object protocol correctly.

Thanks Nick. This looks like a better solution.
Sebastian will test this and we can see the results.