Re: [PATCH v2] clk: imx: Set CLK_SET_RATE_GATE for gate and divider clocks

From: Shawn Guo
Date: Tue Apr 17 2018 - 22:32:57 EST


On Wed, Apr 11, 2018 at 05:03:29PM +0300, Abel Vesa wrote:
> From: Shawn Guo <shawnguo@xxxxxxxxxx>
>
> Add flag CLK_SET_RATE_GATE for i.MX gate and divider clocks on which the
> client drivers usually make clk_set_rate() call, so that the call will fail
> when clock is still on instead of standing the risk of running into glitch
> issue. Rate cannot be changed when the clock is enabled due to the glitchy
> multiplexers.
>
> Signed-off-by: Shawn Guo <shawnguo@xxxxxxxxxx>
> [initial patch from imx internal repo]
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxx>
> [carried over from 3.14 and also applied the flag to newer functions]
> ---
>
> Changes since v1:
> - changed ownership as per initial patch

IIRC, the patch was created on vendor kernel long time ago to work
around a specific glitchy multiplexer issue seen on particular SoC.
I'm not sure it's good for the upstream kernel today.

Shawn