Re: [PATCH v2 02/10] m68k/mac: Fix SWIM memory resource end address

[Geert Uytterhoeven]

Hi Finn,

On Thu, Apr 12, 2018 at 2:50 AM, Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote:
> The resource size is 0x2000 == end - start + 1.
> Therefore end == start + 0x2000 - 1.
>
> Cc: Laurent Vivier <lvivier@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx # v4.14+
> Tested-by: Stan Johnson <userm57@xxxxxxxxx>
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>
> Acked-by: Laurent Vivier <lvivier@xxxxxxxxxx>
> Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Thanks, applied and queued for v4.18.

> --- a/arch/m68k/mac/config.c
> +++ b/arch/m68k/mac/config.c
> @@ -1011,7 +1011,7 @@ int __init mac_platform_init(void)
>                 struct resource swim_rsrc = {
>                         .flags = IORESOURCE_MEM,
>                         .start = (resource_size_t)swim_base,
> -                       .end   = (resource_size_t)swim_base + 0x2000,
> +                       .end   = (resource_size_t)swim_base + 0x1FFF,

BTW, probably you want to change swim_base from u8 * to phys_addr_t, one day.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds